chore: deprecate langdetect components (DocumentLanguageClassifier, TextLanguageRouter)#11662
Draft
julian-risch wants to merge 1 commit into
Draft
chore: deprecate langdetect components (DocumentLanguageClassifier, TextLanguageRouter)#11662julian-risch wants to merge 1 commit into
julian-risch wants to merge 1 commit into
Conversation
Deprecate DocumentLanguageClassifier and TextLanguageRouter, which are moving to the new langdetect-haystack integration package. Update docs to point to the new package and add a deprecation release note. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
DocumentLanguageClassifierandTextLanguageRouterwith aFutureWarningpointing users to the newlangdetect-haystackpackage (feat: add langdetect integration (moved from Haystack core) haystack-core-integrations#3457)How did you test it?
hatch run test:unit test/components/classifiers/test_document_language_classifier.py test/components/routers/test_text_language_router.py: 16 passed (the deprecationFutureWarnings are emitted but don't fail any test)hatch run test:typeson the two changed component files: successlangdetect-haystackpackage in the integration branchNotes for the reviewer
/reference/integrations-langdetectuntil the API reference page is added by the Docusaurus sync workflow whenintegrations/langdetect-v1.0.0is tagged in haystack-core-integrations. Once that sync PR lands onmain, rebasing this branch turns the docs build green — same process as the SerperDev (chore: deprecate SerperDevWebSearch + update docs #11577), SearchApi (chore: deprecate SearchApiWebSearch + update docs #11611), and HuggingFace API (chore: deprecate HF API components + update docs #11513) migrations.LazyImportis kept here (langdetect stays an optional dependency in core), only theFutureWarningis added.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.🤖 Generated with Claude Code