ci: add package-lock.json to git for docs-website - #11783
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Coverage report
This PR does not seem to contain any modification to coverable code. |
anakin87
commented
Jun 26, 2026
| ignore-words-list = "ans,astroid,nd,ned,nin,ue,rouge,ist, Claus,SME" | ||
| quiet-level = 3 | ||
| skip = "./test,./e2e,*.svg" | ||
| skip = "./test,./e2e,*.svg,*/abbreviations/*,*/package-lock.json" |
Member
Author
There was a problem hiding this comment.
- we need to exclude package-lock from codespell
- I also centralized configs here instead of in pre-coomit hooks
anakin87
marked this pull request as ready for review
June 26, 2026 07:21
anakin87
requested review from
julian-risch and
sjrl
and removed request for
a team
June 26, 2026 07:22
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
julian-risch
approved these changes
Jun 26, 2026
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
In #11777,
npm ciwas adopted for security reasons; now it fails withSee https://github.com/deepset-ai/haystack/actions/runs/28211861205/job/83574692472
Proposed Changes:
How did you test it?
Locally executing
npm cinow works. CI.Notes for the reviewer
We could also revert to using
npm installbut this would partially defeat the purpose of the original PR (more security).Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.