fix: raise FilterError on unknown metadata filter operators - #11795
Merged
davidsbatista merged 3 commits intoJun 29, 2026
Merged
Conversation
immuhammadfurqan
requested review from
bogdankostic
and removed request for
a team
June 27, 2026 21:01
|
@immuhammadfurqan is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
Filtering with an unsupported operator (e.g. a typo like "gt" instead of ">", or "XOR" as a logical operator) raised a bare KeyError with no context. Since filters.py is the shared filter engine used by InMemoryDocumentStore and every external document store, this affected all stores. Both _comparison_condition and _logic_condition now validate the operator and raise a FilterError that lists the valid operators, consistent with how other malformed-filter cases are already handled.
immuhammadfurqan
force-pushed
the
fix/filter-unknown-operator-keyerror
branch
from
June 27, 2026 21:04
edcadec to
7bc8312
Compare
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
davidsbatista
requested review from
davidsbatista
and removed request for
bogdankostic
June 29, 2026 07:49
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
davidsbatista
approved these changes
Jun 29, 2026
davidsbatista
left a comment
davidsbatista
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution @immuhammadfurqan .
I extended the tests a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes #11794
Proposed Changes
Metadata filters that use an unsupported operator previously raised a bare
KeyErrorwith no context. Becausehaystack/utils/filters.pyis the shared filter engine used byInMemoryDocumentStoreand every external document store, this cryptic error surfaced across all stores.This PR validates the operator in both
_comparison_conditionand_logic_conditionand raises aFilterErrorlisting the valid operators — consistent with how other malformed-filter cases (missing keys, wrong value types) are already handled.Before
After
How did you test it?
Added two cases to the existing
document_matches_filter_raises_errorparametrization (unknown comparison operator and unknown logical operator). All filter unit tests pass;mypyis clean.Checklist