Raise FilterError for unknown filter operators - #11798
Closed
GioiaZheng wants to merge 1 commit into
Closed
Conversation
|
@GioiaZheng is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Contributor
|
There was already a PR open for this issue #11795 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FilterErrorwith the unsupported operator and the valid operator set instead of a bareKeyError.gt) and logical (XOR) operators.Fixes #11794
Validation
HAYSTACK_TELEMETRY_ENABLED=false pytest test/utils/test_filters.py- 94 passedruff check haystack/utils/filters.py test/utils/test_filters.pyruff format --check haystack/utils/filters.py test/utils/test_filters.pygit diff --check