Skip to content

build(deps): npm audit fix for docs-website to resolve security advisories - #11802

Merged
julian-risch merged 1 commit into
mainfrom
fix-docs-website-npm-audit
Jun 29, 2026
Merged

build(deps): npm audit fix for docs-website to resolve security advisories#11802
julian-risch merged 1 commit into
mainfrom
fix-docs-website-npm-audit

Conversation

@julian-risch

@julian-risch julian-risch commented Jun 29, 2026

Copy link
Copy Markdown
Member

Related Issues

Part of https://github.com/deepset-ai/haystack-private/issues/444

After #11783 committed docs-website/package-lock.json (previously gitignored), the full transitive npm tree became visible to GitHub security scanning for the first time, surfacing 54 advisories. Dependabot's grouped security PR for these then crashed internally (CreateGroupUpdatePullRequest, a sorbet-runtime error — failed run), reporting unknown_error for all 9 deps including dependabot/45 (shell-quote). It could not apply the fixes, so this does them manually.

Proposed Changes:

Apply npm audit fix to docs-websitenon-breaking, lockfile-only. package.json and its declared semver ranges are unchanged.

  • 66 → 60 vulnerabilities; the 1 critical eliminated.
  • shell-quote 1.8.3 → 1.9.0 (critical, dependabot/45 ✓)
  • ws7.5.11 / 8.21.0, tar7.5.7 (high ✓)
  • Covers all 9 deps Dependabot's crashed group targeted (shell-quote, ws, lodash, qs, follow-redirects, webpack-dev-server, fast-uri, launch-editor, @babel/plugin-transform-modules-systemjs).

Not addressed here: the ~42 remaining advisories in the vercel/@vercel/* chain only resolve via npm audit fix --force, which downgrades vercel ^54.2.050.41.0 (a breaking major regression of a direct dependency used for vercel dev and serverless functions). Left for upstream/Dependabot. A further ~18 (mostly @docusaurus/* moderates, serialize-javascript) have no upstream fix reachable in the current tree yet.

How did you test it?

npm run build succeeds locally

Notes for the reviewer

Checklist

🤖 Generated with Claude Code

…ories

Committing docs-website/package-lock.json in #11783 exposed the full
transitive npm tree to GitHub security scanning, surfacing 54 advisories.
Dependabot's grouped security PR crashed internally
(CreateGroupUpdatePullRequest), so it could not apply the fixes.

This applies `npm audit fix` (non-breaking, lockfile-only — package.json
and its declared semver ranges are unchanged). Resolves 6 advisories
including the critical shell-quote (1.8.3 -> 1.9.0, dependabot/45) and the
high-severity ws (-> 7.5.11 / 8.21.0) and tar (-> 7.5.7). Covers all 9
deps Dependabot's crashed group targeted. `npm run build` verified.

The remaining vercel/@vercel chain only resolves via a breaking major
downgrade (vercel 54 -> 50) and is left for upstream/Dependabot.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@julian-risch
julian-risch requested a review from a team as a code owner June 29, 2026 07:22
@julian-risch
julian-risch requested review from bogdankostic and removed request for a team June 29, 2026 07:22
@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
haystack-docs Ready Ready Preview, Comment Jun 29, 2026 7:25am

Request Review

@claude

claude Bot commented Jun 29, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@julian-risch
julian-risch merged commit 4f519e6 into main Jun 29, 2026
22 checks passed
@julian-risch
julian-risch deleted the fix-docs-website-npm-audit branch June 29, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants