ci: rename DC_PIPELINE_IMAGES_PR_URL to HAYSTACK_RUNTIME_PR_URL - #11807
Merged
Conversation
… release workflow
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
davidsbatista
approved these changes
Jun 29, 2026
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes?
Renames the release-notification variable
DC_PIPELINE_IMAGES_PR_URL→HAYSTACK_RUNTIME_PR_URLinrelease.ymlandprepare_release_notification.sh.The name was a leftover from before #11719, which repointed this step from the now-archived
dc-pipeline-imagesrepo tohaystack-runtimebut kept the old variable name — making it misleading (the value already carries the haystack-runtime bump PR URL, and the Slack link is already labeledhaystack-runtime).Also fixes an adjacent doc-comment typo: the optional inputs list said
CUSTOM_NODES_PR_URLbut the script actually readsDC_CUSTOM_NODES_PR_URL.Purely cosmetic — no behavior change. Verified locally by running
prepare_release_notification.shwith mocked env: the new variable renders thehaystack-runtimelink and the old name no longer produces one.Part of the haystack-runtime release-automation cleanup (deepset-ai/haystack-private#388).
How did you test it?
Ran
prepare_release_notification.shlocally with representative RC env vars and asserted the rendered Slack payloadChecklist