ci: revert committed docs-website lockfile and npm ci - #11815
Merged
Conversation
Reverts the package-lock.json addition from #11783 and the switch to `npm ci` in docs_search_sync.yml from #11777. - Remove the committed docs-website/package-lock.json - Restore package-lock.json to docs-website/.gitignore - Drop the now-unneeded */package-lock.json codespell skip entry - Revert `npm ci --ignore-scripts` back to `npm install --ignore-scripts` Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
julian-risch
marked this pull request as ready for review
June 29, 2026 14:08
julian-risch
enabled auto-merge (squash)
June 29, 2026 14:09
bogdankostic
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes https://github.com/deepset-ai/haystack-private/issues/444
Reverts two recent CI changes because they mislead our existing tooling around security. Adding the lock file resulted in issues with the docs website and vercel to be wrongly triggered as Haystack issues.
Revert:
docs-website/package-lock.jsonadded in ci: add package-lock.json to git for docs-website #11783npm installtonpm ciindocs_search_sync.ymlintroduced in ci: pin more dependencies and configure CodeQL checks #11777Proposed Changes:
docs-website/package-lock.jsonpackage-lock.jsontodocs-website/.gitignore*/package-lock.jsonentry from the codespellskiplist inpyproject.tomlnpm ci --ignore-scriptsback tonpm install --ignore-scriptsin.github/workflows/docs_search_sync.ymlHow did you test it?
Notes for the reviewer
#11802 got merged today to address a subset of the issues with the lock file but this PR here now supersedes those changes.
Checklist
ci:.Release note— N/A (CI-only, not user-facing).Unit tests— N/A (CI configuration only).🤖 Generated with Claude Code