test: remove stale TODO and disambiguate PEP 585 param ids in type-utils test - #11866
Merged
sjrl merged 2 commits intoJul 15, 2026
Merged
Conversation
|
@RajanChavada is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
sjrl
added
the
ignore-for-release-notes
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
None — small test-suite cleanup.
Proposed Changes:
test/core/test_type_utils.py
carried a# TODO These tests are failingcomment above four PEP 585 lowercase-generic cases (list[int]vslist, etc.) that all pass today. The comment is stale, and the four params reused the same pytestid=strings as theirtyping.List/Dict/...counterparts, so pytest silently suffixed them0/1, making output confusing. This removes the stale TODO and gives the PEP 585 params distinct-pep585` ids. Tests-only change.How did you test it?
hatch run test:unit test/core/test_type_utils.py -k "bare_container"→ 17 passed.Notes for the reviewer
This change was prepared with Claude Code and reviewed by the author.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.