fix: correct log placeholder kwarg for untriggered pipeline breakpoint warning - #11885
fix: correct log placeholder kwarg for untriggered pipeline breakpoint warning#11885Kropiunig wants to merge 2 commits into
Conversation
|
@Kropiunig is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Hi @Kropiunig - can you please sign the CLA? |
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
|
Please sign the CLA and then ping me again for review |
|
Hi @Kropiunig, thanks a lot for your contribution! 🙏 We noticed that the Contributor License Agreement (CLA) check ( To get your PR reviewed, please sign the CLA via the link in the |
|
fixed by #12017 |
The warning that fires when a pipeline breakpoint is never triggered used the placeholder
{break_point}in its message, but passed the value under the kwargpipeline_breakpoint. Haystack's logger catches the resulting KeyError frommsg.format(**safe_extra)and falls back to the raw string, so users saw the literal text{break_point}instead of the actual breakpoint.Renaming the kwarg to
break_pointso it matches the placeholder makes the message interpolate the real value. One-line change; the message string is unchanged.