Skip to content

Revert "fix: updating generated answer and extracted answers serialisation (#11805)" - #11895

Merged
sjrl merged 1 commit into
mainfrom
revert-11805-answer-serialization
Jul 7, 2026
Merged

Revert "fix: updating generated answer and extracted answers serialisation (#11805)"#11895
sjrl merged 1 commit into
mainfrom
revert-11805-answer-serialization

Conversation

@sjrl

@sjrl sjrl commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Related Issues

  • fixes #issue-number

Proposed Changes:

This reverts commit e40103f.

We will move this update to the v3 branch since its a breaking change.

How did you test it?

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@sjrl
sjrl requested a review from a team as a code owner July 7, 2026 07:58
@sjrl
sjrl requested review from anakin87 and removed request for a team July 7, 2026 07:58
@vercel

vercel Bot commented Jul 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Jul 7, 2026 7:58am

Request Review

@sjrl
sjrl requested a review from julian-risch July 7, 2026 07:58
@sjrl sjrl added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  haystack/dataclasses
  answer.py
Project Total  

This report was generated by python-coverage-comment-action

@claude

claude Bot commented Jul 7, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

anakin87
anakin87 reviewed Jul 7, 2026
View reviewed changes

@anakin87 anakin87 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@sjrl
sjrl merged commit 8d037f2 into main Jul 7, 2026
32 of 33 checks passed
@sjrl
sjrl deleted the revert-11805-answer-serialization branch July 7, 2026 08:10
sjrl added a commit that referenced this pull request Jul 7, 2026
@sjrl
Revert "fix: updating generated answer and extracted answers serialis…
afdb998 
…ation (#11805)" (#11895)
@julian-risch julian-risch mentioned this pull request Jul 10, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anakin87 anakin87 anakin87 approved these changes
@julian-risch julian-risch Awaiting requested review from julian-risch

Assignees

No one assigned

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sjrl @anakin87