chore: consolidate serialize outputs to state string functions - #11898
Closed
davidsbatista wants to merge 3 commits into
Closed
chore: consolidate serialize outputs to state string functions#11898davidsbatista wants to merge 3 commits into
davidsbatista wants to merge 3 commits into
Conversation
…ze_outputs_to_state
…er now in one place
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
davidsbatista
added
the
ignore-for-release-notes
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
anakin87
requested changes
Jul 7, 2026
anakin87
left a comment
anakin87
left a comment
Member
There was a problem hiding this comment.
To avoid duplicate work or fixing stuff that has been removed, I suggest targeting v3 branch (not main).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
tools/tool.pyhad the same small loop copy-pasted: copy a config dict, and if it has a handler, convert it withserialize_callable/deserialize_callable._convert_handler,_convert_handler_in_configs), and had all 4 functions call them instead.How did you test it?
test_serialize_outputs_to_state/test_deserialize_outputs_to_statefirst (they had no dedicated unit tests before, only indirect coverage viaTool.to_dict/from_dictround-trips), confirmed they pass against the old implementation, then refactored.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.