Skip to content

chore!: remove unused raise_on_invalid_filter_syntax utility function - #11947

Merged
anakin87 merged 1 commit into
mainfrom
rm-raise_on_invalid_filter_syntax
Jul 10, 2026
Merged

chore!: remove unused raise_on_invalid_filter_syntax utility function#11947
anakin87 merged 1 commit into
mainfrom
rm-raise_on_invalid_filter_syntax

Conversation

@anakin87

Copy link
Copy Markdown
Member

Related Issues

I noticed raise_on_invalid_filter_syntax utility function:

  • never used across Haystack ecosystem
  • wrong implementation: a possible better implementation can be found in many document stores like Pgvector

Proposed Changes:

  • remove it

How did you test it?

CI

Notes for the reviewer

I also considered fixing it and then reusing it across core integrations, but it seemed high effort for low value

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@anakin87
anakin87 requested a review from a team as a code owner July 10, 2026 08:46
@anakin87
anakin87 requested review from bogdankostic and removed request for a team July 10, 2026 08:46
@vercel

vercel Bot commented Jul 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Jul 10, 2026 8:46am

Request Review

@anakin87 anakin87 self-assigned this Jul 10, 2026
@github-actions github-actions Bot added the type:documentation Improvements on the docs label Jul 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/utils
  __init__.py
  filters.py
Project Total  

This report was generated by python-coverage-comment-action

@julian-risch
julian-risch removed the request for review from bogdankostic July 10, 2026 09:00
@anakin87
anakin87 enabled auto-merge (squash) July 10, 2026 09:02
@anakin87
anakin87 merged commit 3b935d2 into main Jul 10, 2026
25 checks passed
@anakin87
anakin87 deleted the rm-raise_on_invalid_filter_syntax branch July 10, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants