docs: fix replacement locations in MIGRATION.md Generators-removed section - #11948
Merged
Conversation
… main, fix Generators-removed replacements Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
…11805 is being re-landed) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
julian-risch
changed the title
julian-risch
marked this pull request as ready for review
July 11, 2026 08:02
sjrl
approved these changes
Jul 13, 2026
julian-risch
added a commit
that referenced
this pull request
Jul 13, 2026
…on guide Match the MIGRATION.md fix from #11948: HuggingFaceAPIChatGenerator lives in the huggingface-api-haystack integration and HuggingFaceLocalChatGenerator was renamed to TransformersChatGenerator in transformers-haystack, so point readers to the moved-components section instead of implying all chat counterparts are importable from core. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Fix a sentence about "Generators removed" section of
MIGRATION.md.The sentence implied that
OpenAIChatGenerator,AzureOpenAIChatGenerator,HuggingFaceAPIChatGenerator, andHuggingFaceLocalChatGeneratorall live in Haystack core. That is outdated:HuggingFaceLocalChatGeneratorhas been renamed toTransformersChatGeneratorand lives in thetransformers-haystackintegration, andHuggingFaceAPIChatGeneratorlives in thehuggingface-api-haystackintegration. The sentence now states where each replacement lives and links to the "Components Moved to External Packages" section.How did you test it?
Notes for the reviewer
An earlier revision of this PR also removed the
GeneratedAnswer/ExtractedAnswerserialization-format section and its release note, because the #11805 code change had been reverted onmain. I assume #11805 will be re-landed so that the migration entry and release note can stay as they are. I re-opened https://github.com/deepset-ai/haystack-private/issues/327 to track that.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.🤖 Generated with Claude Code