Skip to content

feat: flattened arg support for reasoning mode in GPT-5.6 - #11964

Merged
anakin87 merged 7 commits into
mainfrom
feat/openai_reasoning_mode
Jul 13, 2026
Merged

feat: flattened arg support for reasoning mode in GPT-5.6#11964
anakin87 merged 7 commits into
mainfrom
feat/openai_reasoning_mode

Conversation

@tstadel

@tstadel tstadel commented Jul 10, 2026

Copy link
Copy Markdown
Member

Related Issues

  • fixes #issue-number

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel

vercel Bot commented Jul 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Preview Jul 13, 2026 11:02am

Request Review

@tstadel
tstadel marked this pull request as ready for review July 10, 2026 17:58
@tstadel
tstadel requested a review from a team as a code owner July 10, 2026 17:58
@tstadel
tstadel requested review from anakin87 and removed request for a team July 10, 2026 17:58
@github-actions github-actions Bot added topic:tests type:documentation Improvements on the docs labels Jul 10, 2026
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/components/generators/chat
  openai_responses.py
Project Total  

This report was generated by python-coverage-comment-action

tstadel and others added 6 commits July 10, 2026 20:21
…esolution

_resolve_flattened_kwargs only shallow-copied the top-level dict, so the nested
`reasoning` dict and `include` list were shared with self.generation_kwargs.
Appending "reasoning.encrypted_content" to `include` therefore accumulated a
duplicate on every run() call. Build fresh nested containers instead of mutating
in place, and guard include against duplicates.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01E3LgW8h7fKzDXGw1aBAZML
…_mode

# Conflicts:
#	test/components/generators/chat/test_openai.py

@anakin87 anakin87 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I took the liberty of pushing some changes: merging main to include the fix introduced in #11978; avoiding appending reasoning.encrypted_content multiple times; small refactor.

@anakin87
anakin87 enabled auto-merge (squash) July 13, 2026 11:05
@anakin87
anakin87 merged commit a17ac98 into main Jul 13, 2026
24 checks passed
@anakin87
anakin87 deleted the feat/openai_reasoning_mode branch July 13, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:tests type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants