Skip to content

test: adopt MockTextEmbedder in tests - #12006

Merged
anakin87 merged 1 commit into
mainfrom
adopt-mock-embedders
Jul 15, 2026
Merged

test: adopt MockTextEmbedder in tests#12006
anakin87 merged 1 commit into
mainfrom
adopt-mock-embedders

Conversation

@anakin87

Copy link
Copy Markdown
Member

Related Issues

Proposed Changes:

  • adopt MockTextEmbedder in our tests for consistency and simplicity (where it makes sense)

How did you test it?

CI

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Jul 14, 2026 2:41pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/core/pipeline
  pipeline.py
Project Total  

This report was generated by python-coverage-comment-action

@anakin87 anakin87 changed the title test: adopt MockTextEmbedder test: adopt MockTextEmbedder in tests Jul 14, 2026
@anakin87 anakin87 self-assigned this Jul 14, 2026
@anakin87
anakin87 marked this pull request as ready for review July 14, 2026 14:46
@anakin87
anakin87 requested a review from a team as a code owner July 14, 2026 14:46
@anakin87
anakin87 requested review from bogdankostic and removed request for a team July 14, 2026 14:46

@sjrl sjrl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anakin87
anakin87 merged commit e5069f5 into main Jul 15, 2026
25 checks passed
@anakin87
anakin87 deleted the adopt-mock-embedders branch July 15, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants