Skip to content

fix: ruff 0.16.0 changes - #12158

Merged
sjrl merged 1 commit into
mainfrom
fix-ruff-0.16-too-many-positional-args
Jul 27, 2026
Merged

fix: ruff 0.16.0 changes#12158
sjrl merged 1 commit into
mainfrom
fix-ruff-0.16-too-many-positional-args

Conversation

@sjrl

@sjrl sjrl commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Related Issues

Proposed Changes:

Account for ruff 0.16.0 changes

How did you test it?

Ran hatch run fmt-check

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@sjrl
sjrl requested a review from a team as a code owner July 27, 2026 06:19
@sjrl
sjrl requested review from julian-risch and removed request for a team July 27, 2026 06:19
@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Jul 27, 2026 6:20am

Request Review

@sjrl sjrl self-assigned this Jul 27, 2026
@github-actions github-actions Bot added the type:documentation Improvements on the docs label Jul 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/components/embedders
  azure_document_embedder.py
  openai_document_embedder.py
Project Total  

This report was generated by python-coverage-comment-action

@sjrl sjrl added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jul 27, 2026
@sjrl
sjrl requested a review from anakin87 July 27, 2026 07:19
Comment thread pyproject.toml
exclude = ["e2e/**", "proposals"]
# "*.md": ruff formats Python code blocks inside Markdown; our docs (including the generated
# docs-website API reference) are not managed by ruff.
exclude = ["*.md", "e2e/**", "proposals"]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the future we might check if using Ruff also for formatting code snippets in the docs is convenient (instead of the custom script we use)

@anakin87 anakin87 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sjrl
sjrl merged commit 29fd21e into main Jul 27, 2026
32 of 33 checks passed
@sjrl
sjrl deleted the fix-ruff-0.16-too-many-positional-args branch July 27, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants