Skip to content

fix: in memory doc store get_unique_metadata_values() pagination and case-insensitive + Mixin tests updated - #12168

Open
davidsbatista wants to merge 4 commits into
mainfrom
fix/InMemoryDocStore-get_unique_metadata_values
Open

fix: in memory doc store get_unique_metadata_values() pagination and case-insensitive + Mixin tests updated#12168
davidsbatista wants to merge 4 commits into
mainfrom
fix/InMemoryDocStore-get_unique_metadata_values

Conversation

@davidsbatista

@davidsbatista davidsbatista commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Related Issues

Proposed Changes:

  • adhere to the new get_unique_metadata_values() signature

How did you test it?

  • updated Mixin tests - already being called by the InMemoryDocumentStore tests

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Preview Jul 27, 2026 3:42pm

Request Review

@github-actions github-actions Bot added the type:documentation Improvements on the docs label Jul 27, 2026
@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/document_stores/in_memory
  document_store.py 653
Project Total  

This report was generated by python-coverage-comment-action

@davidsbatista
davidsbatista requested a review from sjrl July 27, 2026 15:50
@davidsbatista
davidsbatista marked this pull request as ready for review July 27, 2026 15:50
@davidsbatista
davidsbatista requested a review from a team as a code owner July 27, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant