Skip to content

feat: add closing methods to components that hold Document Stores - #12169

Merged
anakin87 merged 4 commits into
mainfrom
close-document-stores
Jul 28, 2026
Merged

feat: add closing methods to components that hold Document Stores#12169
anakin87 merged 4 commits into
mainfrom
close-document-stores

Conversation

@anakin87

@anakin87 anakin87 commented Jul 27, 2026

Copy link
Copy Markdown
Member

Related Issues

Proposed Changes:

  • Implement closing methods for components that support multiple Document Stores
    • they delegate to the Document Store if it has closing methods
    • otherwise, they do nothing

How did you test it?

CI, new tests

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Preview Jul 27, 2026 4:15pm

Request Review

@github-actions github-actions Bot added topic:tests type:documentation Improvements on the docs labels Jul 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/components/caching
  cache_checker.py
  haystack/components/retrievers
  auto_merging_retriever.py
  filter_retriever.py
  sentence_window_retriever.py
  haystack/components/writers
  document_writer.py
Project Total  

This report was generated by python-coverage-comment-action

@anakin87 anakin87 changed the title feat: add closing methods to components that hold document stores feat: add closing methods to components that hold Document Stores Jul 27, 2026
@anakin87
anakin87 marked this pull request as ready for review July 27, 2026 16:19
@anakin87
anakin87 requested a review from a team as a code owner July 27, 2026 16:19
@anakin87
anakin87 requested review from sjrl and removed request for a team July 27, 2026 16:19

@sjrl sjrl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anakin87
anakin87 merged commit 090279b into main Jul 28, 2026
27 checks passed
@anakin87
anakin87 deleted the close-document-stores branch July 28, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:tests type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants