fix: validate runtime SentenceWindowRetriever window size - #12183
Merged
julian-risch merged 2 commits intoJul 29, 2026
Merged
Conversation
|
@vinkiYu is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
@julian-risch could you please take a look? |
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Address review feedback on the runtime window_size validation: - Reword the release note from the user's perspective and add an `upgrade` section, since passing `window_size=0` at runtime now raises instead of silently using the constructor value. - Regenerate the release note filename with `hatch run release-note` so it carries reno's hash suffix like every other note. - Revert the unrelated rename of `test_init_with_invalid_window_size_parameter`. - Add sync and async tests asserting that omitting `window_size` uses the constructor value, covering the other half of the changed line. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
julian-risch
approved these changes
Jul 29, 2026
julian-risch
left a comment
julian-risch
left a comment
Member
There was a problem hiding this comment.
Thank you @vinkiYu ! I applied some smaller and the PR looks good to me now. Congratulations on your first PR merged into Haystack!
julian-risch
enabled auto-merge (squash)
July 29, 2026 10:23
julian-risch
changed the title
julian-risch
disabled auto-merge
July 29, 2026 10:23
julian-risch
enabled auto-merge (squash)
July 29, 2026 10:23
vinkiYu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the standalone SentenceWindowRetriever part requested by the maintainer in #12167.
Tests
Relationship to #12167
The FilterRetriever change from #12167 is intentionally not included because {} is not a valid Haystack filter dict and changing its meaning would be a breaking behavior change.