fix: deferred annotation pickup in Agent - #12185
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
anakin87
approved these changes
Jul 29, 2026
| hints = {} | ||
| # Every parameter is always in the returned dict; only its type may stay unresolved, as the raw string. | ||
| return { | ||
| name: hints.get(name, param.annotation) if isinstance(param.annotation, str) else param.annotation |
Member
There was a problem hiding this comment.
Suggested change
| name: hints.get(name, param.annotation) if isinstance(param.annotation, str) else param.annotation | |
| name: hints.get(name, param.annotation) |
we don't need the condition, right?
Contributor
Author
There was a problem hiding this comment.
I think we technically want to keep this b/c this allows us to prefer param.annotation over the hints. This is b/c the hints can expand a param's type to include optional if its default value is None. E.g. param: int = None
Member
There was a problem hiding this comment.
Ah, I understand and I see that this is true for Python <= 3.10
In 3.11, they changed this aspect -> https://docs.python.org/3/whatsnew/3.11.html#typing
Worth a small comment in the code?
sjrl
enabled auto-merge (squash)
July 29, 2026 10:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Tool functions defined in a module using
from __future__ import annotationsare now inspected correctly byAgent. Postponed annotations are stored as strings, so a parameter annotated withStatewas not recognized and the liveStateobject was not injected into the tool call. The annotations are now resolved before they are inspected.Also consolidated the repeated logic into one util function.
How did you test it?
New tests.
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.