feat: add resource name for Haystack Component Datadog spans#9337
Conversation
|
@lan666as thanks for the work on this! We will be able to give this a review once you are able to add tests and mark the PR as ready. |
Pull Request Test Coverage Report for Build 15728163096Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Hi @sjrl, it seems the changes needed for our requirements are more extensive than anticipated. I've decided to fork the class to implement these independently and will be closing this PR. Thanks! |
|
@lan666as looking good! Could you also update tests in |
Signed-off-by: Ahmad Zidan <ahmad.zidan@traveloka.com>
c319db5 to
bba3f8e
Compare
|
Let me resolve the CI issue first |
Signed-off-by: Ahmad Zidan <ahmad.zidan@traveloka.com>
57c322d to
987f98a
Compare
Related Issues
Proposed Changes:
Set Datadog span resource name as component name and type instead of the operation name (i.e.,
haystack.component.run)How did you test it?
Before
After
Notes for the reviewer
-
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.