feat: Adding watsonx support in Haystack #9478
Closed
divyaruhil wants to merge 4 commits intodeepset-ai:mainfrom
Closed
feat: Adding watsonx support in Haystack #9478divyaruhil wants to merge 4 commits intodeepset-ai:mainfrom
divyaruhil wants to merge 4 commits intodeepset-ai:mainfrom
Conversation
Contributor
|
Hey @divyaruhil we appreciate your work on this, but take a look at my comment here deepset-ai/haystack-core-integrations#1891 (comment) |
Author
|
Sure @sjrl , I'll go through the comment , Thankyou ! |
10 tasks
Author
|
Closing this one as i have opened a pr :- deepset-ai/haystack-core-integrations#1949 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
#link
Proposed Changes:
Add WatsonxGenerator and WatsonxChatGenerator components to wrap IBM watsonx.ai’s text- and chat-generation APIs (supporting streaming, custom models, and generation parameters).
Add WatsonxTextEmbedder and WatsonxDocumentEmbedder components that support embedding use cases for both text and documents.
Ensure all components follow the existing Haystack interfaces and patterns for Generator and Embedder.
Include tests files accordingly.
How did you test it?
--Text generation works with WatsonxGenerator
--Chat generation works with WatsonxChatGenerator
-- Embeddings are correctly generated for both text and documents using the respective embedder components
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.