Conversation
Pull Request Test Coverage Report for Build 15486550666Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@sjrl thanks a lot for this. Nice & clean, looking great!
Looking forward to having this! |
|
@mpangrazzi just realized I should add a specific test for this since I'm unsure if So for this to work as expected for |
mpangrazzi
left a comment
There was a problem hiding this comment.
Looks good! I've added two comments, one might be relevant.
Added a test and a fix for this. New utility method called |
Related Issues
Proposed Changes:
Add
enable_streaming_passthroughat the request of the platform team (@tstadel). This is to allow theToolInvokerto pass thestreaming_callbackto the tool invocation if the tool supports it. This only occurs if this flag is set to True and if the tool has astreaming_callbackparameter in itsinvokemethod signature. This is to more easily enable Tools that contain Components or SuperComponents that support streaming (e.g. Agent) and allow them to stream in a deployment setting. @tstadel has more details on the complexity on this.Fixed the
to_dictandfrom_dictmethods ofToolInvokerto properly serliaze it's init parameters. For example,streaming_callbackserialization was missing.How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.