Skip to content

Make ComponentTool a proper dataclass#9501

Closed
sjrl wants to merge 1 commit intomainfrom
make-component-tool-a-dataclass
Closed

Make ComponentTool a proper dataclass#9501
sjrl wants to merge 1 commit intomainfrom
make-component-tool-a-dataclass

Conversation

@sjrl
Copy link
Copy Markdown
Contributor

@sjrl sjrl commented Jun 6, 2025

Related Issues

  • fixes #issue-number

Proposed Changes:

Just an experiment. By adding the decorator we make ComponentTool a proper dataclass. I think this is mostly for best practice since I can't immediately tell the benefit from doing this. I checked and all instances of ComponentTool are dataclasses because we do run super().__init__() in ComponentTool's __init__ method.

How did you test it?

Want to see if this change breaks any tests

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@coveralls
Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 15486035323

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 90.42%

Files with Coverage Reduction New Missed Lines %
tools/component_tool.py 6 92.55%
Totals Coverage Status
Change from base Build 15484500747: 0.001%
Covered Lines: 11487
Relevant Lines: 12704

💛 - Coveralls

@sjrl
Copy link
Copy Markdown
Contributor Author

sjrl commented Jun 6, 2025

Closing as I don't think this is really needed

@sjrl sjrl closed this Jun 6, 2025
@sjrl sjrl deleted the make-component-tool-a-dataclass branch June 10, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants