Skip to content

chore: cleanup - lint and tests#9504

Merged
anakin87 merged 1 commit intomainfrom
general-cleanup
Jun 11, 2025
Merged

chore: cleanup - lint and tests#9504
anakin87 merged 1 commit intomainfrom
general-cleanup

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Jun 9, 2025

Proposed Changes:

  • review pylint/ruff settings to increase strictness where possible
  • minor type/format fixes
  • make sure that document_store fixture is correctly shutdown in InMemoryDocumentStore tests (similar to test: prevent DocumentWriter tests from blocking CI #9448)
  • avoid that Pipeline tests permanently write files on disk (using temp files)
  • mark 2 slow unit tests (5s in my macOS) as integration tests -> this is the reason why coverage decreases

How did you test it?

CI

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@coveralls
Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 15536223117

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 46 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.3%) to 90.213%

Files with Coverage Reduction New Missed Lines %
tools/component_tool.py 1 92.47%
core/serialization.py 3 96.47%
components/extractors/llm_metadata_extractor.py 9 82.3%
core/pipeline/base.py 33 86.87%
Totals Coverage Status
Change from base Build 15490301533: -0.3%
Covered Lines: 11513
Relevant Lines: 12762

💛 - Coveralls

@anakin87 anakin87 changed the title chore: clean up chore: cleanup - lint and tests Jun 9, 2025
@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jun 9, 2025
Comment thread pyproject.toml
python_version = "3.9"
disallow_incomplete_defs = true
warn_return_any = false
warn_unused_configs = true
Copy link
Copy Markdown
Member Author

@anakin87 anakin87 Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enabling this argument without setting incremental = False does not work (mypy docs)

And incremental mode is useful for speeding up the execution of mypy locally

@anakin87 anakin87 marked this pull request as ready for review June 9, 2025 14:05
@anakin87 anakin87 requested a review from a team as a code owner June 9, 2025 14:05
@anakin87 anakin87 requested review from julian-risch and removed request for a team June 9, 2025 14:05
Copy link
Copy Markdown
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me! 🚀

@anakin87 anakin87 merged commit f8155e1 into main Jun 11, 2025
23 of 24 checks passed
@anakin87 anakin87 deleted the general-cleanup branch June 11, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution topic:core topic:tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants