Skip to content

fix: Fix Tool and ComponentTool serialization when specifying outputs_to_string#9524

Merged
sjrl merged 8 commits intomainfrom
fix-component-tool-sede
Jun 18, 2025
Merged

fix: Fix Tool and ComponentTool serialization when specifying outputs_to_string#9524
sjrl merged 8 commits intomainfrom
fix-component-tool-sede

Conversation

@sjrl
Copy link
Copy Markdown
Contributor

@sjrl sjrl commented Jun 17, 2025

Related Issues

Proposed Changes:

Update to_dict method of ComponentTool and Tool to properly serialize outputs_to_string. Added unit tests.

How did you test it?

Added unit tests.

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@sjrl sjrl requested review from a team as code owners June 17, 2025 07:00
@sjrl sjrl requested review from davidsbatista and dfokina and removed request for a team June 17, 2025 07:00
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Jun 17, 2025

Pull Request Test Coverage Report for Build 15727984160

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.04%) to 90.178%

Files with Coverage Reduction New Missed Lines %
core/super_component/super_component.py 1 95.92%
tools/component_tool.py 2 94.74%
Totals Coverage Status
Change from base Build 15727109961: 0.04%
Covered Lines: 11559
Relevant Lines: 12818

💛 - Coveralls

@github-actions github-actions Bot added the type:documentation Improvements on the docs label Jun 18, 2025
@sjrl sjrl merged commit 3784889 into main Jun 18, 2025
19 checks passed
@sjrl sjrl deleted the fix-component-tool-sede branch June 18, 2025 09:00
julian-risch pushed a commit that referenced this pull request Jun 18, 2025
…s_to_string` (#9524)

* Fix serialization of outputs_to_string in Tool and ComponentTool

* Add reno

* Fix mypy, simplify logic

* fix pylint

* Fix test

---------

Co-authored-by: David S. Batista <dsbatista@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:tests type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Issue deserializing an Agent with ComponentTool in tools

3 participants