chore: update linter configuration for compatibility with latest ruff release#9528
Merged
chore: update linter configuration for compatibility with latest ruff release#9528
Conversation
Amnah199
added
the
ignore-for-release-notes
Collaborator
Pull Request Test Coverage Report for Build 15726914697Details
💛 - Coveralls |
anakin87
reviewed
Jun 18, 2025
| "PLC0414", # useless-import-alias | ||
| "PLC0414", # useless-import-alias, | ||
| "PLC0415", # import-outside-top-level, | ||
| "PLW1641", # eq-without-hash |
Member
There was a problem hiding this comment.
With @sjrl, we thought that eq-without-hash might be useful: https://docs.astral.sh/ruff/rules/eq-without-hash/
It currently affects Document, Sockets and PipelineBase.
What I suggest:
- ignore this rule not in pyproject but adding specific comments where appropriate (https://docs.astral.sh/ruff/linter/#error-suppression)
- create an issue about investigating if it makes sense to implement
__hash__forDocument,SocketsandPipelineBase.
anakin87
reviewed
Jun 18, 2025
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
Let's also update our ruff pre-commit hook
haystack/.pre-commit-config.yaml
Lines 19 to 20 in 6198f0c
8 tasks
anakin87
approved these changes
Jun 18, 2025
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
Thanks!
(Will you open the issue about __hash__ or should I take care?)
Contributor
Author
julian-risch
pushed a commit
that referenced
this pull request
Jun 18, 2025
… release (#9528) * Fix linting * Fix linting * Update error suppression * Update pre commit * Update pyproject.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
pyproject.tomlto ignore new rules introduced in the latest ruff releaseChecklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.