feat: enable parallel tool execution in ToolInvoker#9530
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 15872972654Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
sjrl
reviewed
Jun 18, 2025
sjrl
reviewed
Jun 18, 2025
mpangrazzi
reviewed
Jun 20, 2025
Contributor
mpangrazzi
left a comment
There was a problem hiding this comment.
Looks generally good, I've added a few comments!
9 tasks
anakin87
reviewed
Jun 24, 2025
sjrl
reviewed
Jun 24, 2025
sjrl
reviewed
Jun 24, 2025
Contributor
|
@Amnah199 as a general comment could we align the implementations of run and run_async to match as closely as possible? I realize they can't exactly be the same, but it would be great if we could minimize the differences so they are easier to both update at the same time in the future. For example, |
mpangrazzi
reviewed
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
run_asyncto gather alltool_callsand execute them in parallel.How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.