Skip to content

feat: add trust_remote_code parameter to SentenceTransformersSimilarityRanker#9546

Merged
anakin87 merged 1 commit intomainfrom
st-similarity-ranker-trust-remote-code
Jun 24, 2025
Merged

feat: add trust_remote_code parameter to SentenceTransformersSimilarityRanker#9546
anakin87 merged 1 commit intomainfrom
st-similarity-ranker-trust-remote-code

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Jun 24, 2025

Related Issues

Proposed Changes:

How did you test it?

CI, improved tests

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@github-actions github-actions Bot added topic:tests type:documentation Improvements on the docs labels Jun 24, 2025
@coveralls
Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 15845616329

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 90.182%

Files with Coverage Reduction New Missed Lines %
components/rankers/sentence_transformers_similarity.py 1 98.75%
Totals Coverage Status
Change from base Build 15819151860: 0.001%
Covered Lines: 11573
Relevant Lines: 12833

💛 - Coveralls

@anakin87 anakin87 marked this pull request as ready for review June 24, 2025 08:49
@anakin87 anakin87 requested review from a team as code owners June 24, 2025 08:49
@anakin87 anakin87 requested review from dfokina and julian-risch and removed request for a team June 24, 2025 08:49
Copy link
Copy Markdown
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@anakin87 anakin87 merged commit d14f5dc into main Jun 24, 2025
25 checks passed
@anakin87 anakin87 deleted the st-similarity-ranker-trust-remote-code branch June 24, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:tests type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot pass trust_remote_code to SentenceTransformersSimilarityRanker

3 participants