Make Toolset.add chainable and flatten nested toolsets#9556
Closed
gulbaki wants to merge 2 commits intodeepset-ai:mainfrom
Closed
Make Toolset.add chainable and flatten nested toolsets#9556gulbaki wants to merge 2 commits intodeepset-ai:mainfrom
gulbaki wants to merge 2 commits intodeepset-ai:mainfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 15904837847Details
💛 - Coveralls |
Contributor
|
Hey @vblagoje since you have the most context on |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
add()to returnselftoolset.add(a).add(b)How did you test it?
test_toolset_add_can_flatten_nested_toolsetsRelease notes
Added in
releasenotes/notes/toolset-add-chainable.yaml