fix: adjust the async executor in ToolInvoker#9562
Merged
Conversation
Amnah199
added
the
ignore-for-release-notes
Collaborator
Pull Request Test Coverage Report for Build 15973645048Details
💛 - Coveralls |
Amnah199
requested review from
mpangrazzi and
vblagoje
and removed request for
a team
mpangrazzi
reviewed
Jun 30, 2025
Contributor
mpangrazzi
left a comment
mpangrazzi
left a comment
There was a problem hiding this comment.
I've left some comments!
Also, as discussed, we may need to have two final "acceptance" tests with e.g. 2 concurrent run() / run_async() calls (which in turn call multiple tools as in other tests).
Amnah199
commented
Jun 30, 2025
Comment on lines
+780
to
+782
| else: | ||
| with ThreadPoolExecutor(max_workers=self.max_workers) as executor: | ||
| # 3) Create async tasks for valid tool calls |
Contributor
Author
There was a problem hiding this comment.
@mpangrazzi so I separated the two cases as the previously initialized executor cannot be used with context manager. There is a lot of code duplication now, but this will be removed in 2.16.
Wdyt?
mpangrazzi
approved these changes
Jun 30, 2025
Contributor
mpangrazzi
left a comment
mpangrazzi
left a comment
There was a problem hiding this comment.
Looks good! Will look even better in 2.16 ;)
Amnah199
added a commit
that referenced
this pull request
Jun 30, 2025
* Fix bug * Add a new test * PR comments * Add another test * Small fix * Fix linting * Update tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
ToolInvoker.run_asyncshuts down persistent executor after first use #9560Proposed Changes:
Remove the context manager for executor in
run_async.How did you test it?
Added the test mentioned in the issue.
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.