Skip to content

fix: Fix _convert_streaming_chunks_to_chat_message#9566

Merged
sjrl merged 3 commits intomainfrom
fix-convert-streaming-chunks-to-chat-message
Jun 30, 2025
Merged

fix: Fix _convert_streaming_chunks_to_chat_message#9566
sjrl merged 3 commits intomainfrom
fix-convert-streaming-chunks-to-chat-message

Conversation

@sjrl
Copy link
Copy Markdown
Contributor

@sjrl sjrl commented Jun 30, 2025

Related Issues

  • fixes #issue-number

Proposed Changes:

This should have been already included in the PR #9525 but was overlooked. It was missed in tests, because it only becomes necessary for certain providers like Mistral. So it was caught while working on this PR in this commit.

How did you test it?

Added a unit test to have in main, not just in core-integrations.

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@sjrl sjrl requested a review from a team as a code owner June 30, 2025 09:26
@sjrl sjrl removed the request for review from a team June 30, 2025 09:26
@sjrl sjrl requested a review from a team as a code owner June 30, 2025 09:26
@sjrl sjrl requested review from dfokina, julian-risch and vblagoje and removed request for a team June 30, 2025 09:26
@sjrl
Copy link
Copy Markdown
Contributor Author

sjrl commented Jun 30, 2025 •
edited
Loading

@julian-risch tagging you since this is a follow up to this PR #9525 and should definitely be included in the 2.15.1 release. I have added it to the milestone.

@sjrl sjrl added this to the 2.15.1 milestone Jun 30, 2025
@sjrl sjrl self-assigned this Jun 30, 2025
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Jun 30, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15969229130

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.254%
Files with Coverage Reduction New Missed Lines %
components/generators/utils.py 2 74.51%
core/pipeline/async_pipeline.py 3 67.74%
Totals Coverage Status
Change from base Build 15922791869: -0.02%
Covered Lines: 11705
Relevant Lines: 12969
💛 - Coveralls

julian-risch
julian-risch approved these changes Jun 30, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@sjrl sjrl merged commit fc64884 into main Jun 30, 2025
19 checks passed
@sjrl sjrl deleted the fix-convert-streaming-chunks-to-chat-message branch June 30, 2025 09:51
Amnah199 pushed a commit that referenced this pull request Jun 30, 2025
@sjrl @Amnah199
fix: Fix _convert_streaming_chunks_to_chat_message (#9566)
cc675fc 
* Fix conversion

* Add reno

* Add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julian-risch julian-risch julian-risch approved these changes

@vblagoje vblagoje Awaiting requested review from vblagoje vblagoje is a code owner automatically assigned from deepset-ai/open-source-engineering

@dfokina dfokina Awaiting requested review from dfokina dfokina was automatically assigned from deepset-ai/documentation

Assignees

@sjrl sjrl

Labels

topic:tests

Projects

None yet

Milestone

2.15.1

Development

Successfully merging this pull request may close these issues.

3 participants

@sjrl @coveralls @julian-risch