feat: Add to_dict and from_dict to ByteStream#9568
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 15972070708Details
💛 - Coveralls |
vblagoje
approved these changes
Jun 30, 2025
Member
vblagoje
left a comment
There was a problem hiding this comment.
Looks great. A small code comment that JSON doesn’t support raw binary data (self.bytes) so we need to use a list of integers as serialization format - would be helpful. But also optional as one can easily figure that out. As you wish 👍
Contributor
Author
Thanks! I added a code comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
to_dict/from_dictto ByteStream #9543Proposed Changes:
to_dictandfrom_dictto ByteStreamDocument.to_dictandfrom_dictto use the ByteStream methodsmetafield which is now included.How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.