Skip to content

chore: remove deprecated async_executor param from ToolInvoker#9571

Merged
Amnah199 merged 5 commits intomainfrom
remove-async-executor-toolinvoker
Jul 2, 2025
Merged

chore: remove deprecated async_executor param from ToolInvoker#9571
Amnah199 merged 5 commits intomainfrom
remove-async-executor-toolinvoker

Conversation

@Amnah199
Copy link
Copy Markdown
Contributor

Related Issues

Proposed Changes:

Remove the async_executor and associated logic.

How did you test it?

Updated the tests

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@Amnah199 Amnah199 changed the title chore: remove deprecated async_executor param from ToolIinvoker chore: remove deprecated async_executor param from ToolInvoker Jun 30, 2025
@github-actions github-actions Bot added the type:documentation Improvements on the docs label Jun 30, 2025
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Jun 30, 2025

Pull Request Test Coverage Report for Build 16022490415

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 90.439%

Files with Coverage Reduction New Missed Lines %
components/tools/tool_invoker.py 27 88.03%
Totals Coverage Status
Change from base Build 16022483787: 0.07%
Covered Lines: 11710
Relevant Lines: 12948

💛 - Coveralls

@Amnah199 Amnah199 marked this pull request as ready for review July 1, 2025 10:44
@Amnah199 Amnah199 requested review from a team as code owners July 1, 2025 10:44
@Amnah199 Amnah199 requested review from davidsbatista, dfokina and mpangrazzi and removed request for a team and davidsbatista July 1, 2025 10:44
Copy link
Copy Markdown
Contributor

@mpangrazzi mpangrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Amnah199 Amnah199 merged commit 9fd552f into main Jul 2, 2025
19 checks passed
@Amnah199 Amnah199 deleted the remove-async-executor-toolinvoker branch July 2, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:tests type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: remove async_executor param in ToolInvoker

3 participants