feat: Add Chat Generator supporting OpenAI Responses API#9808
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 19132972551Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
…tack into openai-responses
sjrl
reviewed
Oct 14, 2025
sjrl
reviewed
Oct 14, 2025
sjrl
reviewed
Oct 14, 2025
sjrl
reviewed
Oct 14, 2025
sjrl
reviewed
Oct 14, 2025
sjrl
reviewed
Oct 14, 2025
sjrl
reviewed
Oct 14, 2025
sjrl
reviewed
Oct 14, 2025
sjrl
reviewed
Nov 5, 2025
sjrl
reviewed
Nov 5, 2025
sjrl
reviewed
Nov 5, 2025
sjrl
reviewed
Nov 5, 2025
sjrl
reviewed
Nov 5, 2025
sjrl
reviewed
Nov 5, 2025
sjrl
reviewed
Nov 5, 2025
sjrl
reviewed
Nov 6, 2025
sjrl
reviewed
Nov 6, 2025
Contributor
|
@Amnah199 can we make sure to update the docs files in |
sjrl
reviewed
Nov 6, 2025
Amnah199
commented
Nov 6, 2025
| timeout: Optional[float] = None, | ||
| max_retries: Optional[int] = None, | ||
| tools: Optional[Union[ToolsType, list[dict]]] = None, | ||
| tools_strict: bool = False, |
Contributor
Author
There was a problem hiding this comment.
@sjrl This value is True by default in Responses. For consistency with other chat generators I kept it false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
responsesendpoint.initandrunmethods allows openai and MCP tools besides haystack Tools.text_formatingeneration_kwargs.generation_kwargs.backgroundrequests etc, which are not supported in this iteration.How did you test it?
Notes for the reviewer
Using OpenAI tools and MCP tools doesn’t behave like standard function calls.
type="function_call". However, for OpenAI/MCP tools, the type value varies depending on the tool being used — for example,type="web_search_call".ResponseFunctionToolCallobjects. As a result, tool calls from OpenAI/MCP tools won’t appear in theChatMessage, so the user won’t see them.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.