Skip to content

fix: Add type hint#9899

Merged
sjrl merged 1 commit into
mainfrom
fix-mypy-jinja2-extension
Oct 20, 2025
Merged

fix: Add type hint#9899
sjrl merged 1 commit into
mainfrom
fix-mypy-jinja2-extension

Conversation

@sjrl

@sjrl sjrl commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

Related Issues

Proposed Changes:

Adds type hint to a kwargs dict so mypy no longer complains. Arrow had a new release 2 days ago https://pypi.org/project/arrow/1.4.0/ but I can't immediately tell if that change caused this issue.

How did you test it?

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@sjrl sjrl requested a review from a team as a code owner October 20, 2025 06:35
@sjrl sjrl requested review from anakin87 and mpangrazzi and removed request for a team and mpangrazzi October 20, 2025 06:35
@sjrl sjrl added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Oct 20, 2025
@sjrl sjrl self-assigned this Oct 20, 2025
@coveralls

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 18644271339

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.2%

Totals Coverage Status
Change from base Build 18643827377: 0.0%
Covered Lines: 13346
Relevant Lines: 14475

💛 - Coveralls

@anakin87 anakin87 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sjrl sjrl merged commit e03add6 into main Oct 20, 2025
21 of 22 checks passed
@sjrl sjrl deleted the fix-mypy-jinja2-extension branch October 20, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants