fix: Add warm_up() calls to tests after ChatGenerator tool initialization changes#9965
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Collaborator
Pull Request Test Coverage Report for Build 18906379731Details
💛 - Coveralls |
sjrl
approved these changes
Oct 29, 2025
sjrl
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just an update to the reno!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Fixes failing tests on main branch after PR #9942 which introduced the
warm_up()method requirement for ChatGenerator components when using tools. Tests were failing because Agent and LLMMessagesRouter components now require explicit warm-up calls before execution to properly initialize tools.What:
agent.warm_up()calls intest_agent_breakpoints.pybefore agent execution with toolsrouter.warm_up()call intest_llm_messages_router.pybefore router execution with toolsagent.warm_up()calls (2 locations) intest_pipeline_tool.pyfor both sync and async test casesHow can it be used:
After PR #9942, all Agent and LLMMessagesRouter usage with tools must call
warm_up()before execution:How did you test it:
warm_up()callsNotes for the reviewer:
This is a direct follow-up to PR #9942 which introduced tool warm-up for ChatGenerators. The release note is categorized as a
fixrather thanupgradesince it documents the resolution of the test failures and provides migration guidance. All changes are minimal—just adding the requiredwarm_up()calls before component execution.Related Issues