Skip to content

chore: Improve Agent pydoc#9997

Merged
vblagoje merged 3 commits into
mainfrom
agent_pydoc
Nov 4, 2025
Merged

chore: Improve Agent pydoc#9997
vblagoje merged 3 commits into
mainfrom
agent_pydoc

Conversation

@vblagoje

@vblagoje vblagoje commented Oct 31, 2025

Copy link
Copy Markdown
Member
  • Improves Agent pydoc with working short interesting example
  • This snippet will be in main Agent API doc and tested daily for regression and correctness

@vblagoje vblagoje requested a review from a team as a code owner October 31, 2025 13:22
@vblagoje vblagoje added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Oct 31, 2025
@vblagoje vblagoje requested review from mpangrazzi and removed request for a team October 31, 2025 13:22
@vercel

vercel Bot commented Oct 31, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
haystack-docs Ignored Ignored Preview Nov 4, 2025 8:42am

@vblagoje vblagoje requested a review from sjrl October 31, 2025 13:22
@github-actions github-actions Bot added the type:documentation Improvements on the docs label Oct 31, 2025
@vblagoje vblagoje requested a review from dfokina October 31, 2025 13:22
@vblagoje

vblagoje commented Oct 31, 2025

Copy link
Copy Markdown
Member Author

Required for #9967 and in general

@coveralls

coveralls commented Oct 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 19062763536

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 92.248%
Files with Coverage Reduction New Missed Lines %
components/agents/agent.py 9 96.48%
utils/base_serialization.py 16 87.6%
Totals Coverage Status
Change from base Build 18971464217: 0.03%
Covered Lines: 13507
Relevant Lines: 14642
💛 - Coveralls

dfokina
dfokina approved these changes Oct 31, 2025
View reviewed changes

@dfokina dfokina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sjrl
sjrl reviewed Nov 4, 2025
View reviewed changes
Comment thread haystack/components/agents/agent.py Outdated
)

# Run the agent
agent.warm_up()

@sjrl sjrl Nov 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vblagoje this isn't needed anymore since merging #9987 but also fine to leave

@vblagoje vblagoje Nov 4, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No no let's remove it. Give me a sec

sjrl
sjrl approved these changes Nov 4, 2025
View reviewed changes

@sjrl sjrl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vblagoje vblagoje enabled auto-merge (squash) November 4, 2025 08:43
@vblagoje vblagoje merged commit eae41ca into main Nov 4, 2025
19 checks passed
@vblagoje vblagoje deleted the agent_pydoc branch November 4, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjrl sjrl sjrl approved these changes
@dfokina dfokina dfokina approved these changes
@mpangrazzi mpangrazzi Awaiting requested review from mpangrazzi mpangrazzi is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees

No one assigned

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vblagoje @coveralls @sjrl @dfokina