Fix Replay Data Corruption for Non-JSON Payloads (#2813)#12
Open
deepshekhardas wants to merge 1 commit into
Open
Fix Replay Data Corruption for Non-JSON Payloads (#2813)#12deepshekhardas wants to merge 1 commit into
deepshekhardas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes replay data corruption for non-JSON payloads by:\n- Allowing non-JSON string payloads in replay (removing JSON.parse validation)\n- Detecting large payloads and preventing editing them\n- Properly showing tooltip for large vs store payloads\n\nCloses triggerdotdev#2959
Summary by cubic
Prevents replay data corruption for non-JSON payloads by allowing raw string payloads and making oversized or stored payloads read-only. Improves clarity in the replay dialog with accurate tooltips for large vs too-large payloads. Closes triggerdotdev#2959.
ReplayRunData(removed JSON validation) to preserve non-JSON data.application/storeand >512 KB payloads as read-only and show the correct tooltip.Written for commit c7507f0. Summary will update on new commits. Review in cubic