Skip to content

Commit ed7c681

Browse files
committed
apply review suggestions
Signed-off-by: Hongwei Chen <hongweichen@microsoft.com>
1 parent f479dbf commit ed7c681

4 files changed

Lines changed: 6 additions & 17 deletions

File tree

training/DeepSpeed-Domino/domino/training.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,6 @@ def train(forward_step_func, model, optimizer, opt_param_scheduler,
460460
time_list.append(ite_time)
461461

462462

463-
# ite_time = timers('ite-time').elapsed(barrier=True)
464463
if iteration % args.log_interval == 0 and is_rank_0():
465464
loss = loss_dict['lm loss'].item()
466465
print( 'iteration: {} | loss: {:.3f} | iteration time (ms): {:.2f} '.format(iteration, loss, ite_time))

training/DeepSpeed-Domino/pretrain_gpt.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -64,16 +64,6 @@ def forward_step(data_iterator, model):
6464
data_iterator)
6565
timers('batch-generator').stop()
6666
output_tensor = model(tokens, position_ids, attention_mask, labels=labels)
67-
# start = torch.cuda.Event(enable_timing=True)
68-
# end = torch.cuda.Event(enable_timing=True)
69-
# start.record()
70-
# output_tensor = model(tokens, position_ids, attention_mask, labels=labels)
71-
# end.record()
72-
# torch.cuda.synchronize()
73-
74-
# if is_rank_0():
75-
# print('forward time: ')
76-
# print(start.elapsed_time(end))
7767

7868
return output_tensor, partial(loss_func, loss_mask)
7969

training/DeepSpeed-Domino/pretrain_gpt3_13b.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ NODE_RANK=0
1313
WORLD_SIZE=$(($GPUS_PER_NODE*$NNODES))
1414

1515

16-
VOCAB_FILE="/home/code/dataset/gpt2-vocab.json"
17-
MERGE_FILE="/home/code/dataset/gpt2-merges.txt"
18-
DATA_PATH="/home/code/dataset/BookCorpusDataset_text_document"
16+
VOCAB_FILE="dataset/gpt2-vocab.json"
17+
MERGE_FILE="dataset/gpt2-merges.txt"
18+
DATA_PATH="dataset/BookCorpusDataset_text_document"
1919

2020

2121
SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"

training/DeepSpeed-Domino/pretrain_gpt3_6.7b.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ NODE_RANK=0
1313
WORLD_SIZE=$(($GPUS_PER_NODE*$NNODES))
1414

1515

16-
VOCAB_FILE="/home/code/dataset/gpt2-vocab.json"
17-
MERGE_FILE="/home/code/dataset/gpt2-merges.txt"
18-
DATA_PATH="/home/code/dataset/BookCorpusDataset_text_document"
16+
VOCAB_FILE="dataset/gpt2-vocab.json"
17+
MERGE_FILE="dataset/gpt2-merges.txt"
18+
DATA_PATH="dataset/BookCorpusDataset_text_document"
1919

2020
SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
2121
SCRIPT_DIR="$SCRIPT_DIR/Megatron-LM"

0 commit comments

Comments
 (0)