Add data-output tests for plotPCA and plotFingerprint#1435
Merged
Conversation
Both existing tests only compared the rendered PNG. Adds numeric assertions on the tabular outputs, filling gaps found while triaging the stalled #1372/#1374 tests: - plotPCA: verify --outFileNameData (the existing test passed this flag but the check was commented out). Asserts the sign-independent eigenvalue column and table shape. - plotFingerprint: verify --outQualityMetrics + --JSDsample (AUC and JS Distance), neither previously tested anywhere. Expected values derived by running the current tools; verified with `pixi run pytest`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the test-salvage work. Both existing plot tests only compared the rendered PNG; this adds numeric assertions on the tabular outputs, closing the last two coverage gaps surfaced while triaging the stalled #1372 / #1374 tests.
plotPCA (
test_plotPCA.py)--outFileNameData. The existingtest_plotPCA_defaultalready passed this flag, but the assertion on it was commented out. New test asserts the eigenvalue column and table shape — deliberately sign-independent, since PCA eigenvector signs can flip across BLAS/platforms (this suite runs on Linux + OSX + aarch64).plotFingerprint (
test_plotFingerprint.py)--outQualityMetricstogether with--JSDsample(AUC per sample and JS Distance). Neither the quality-metrics table nor the JSD computation was tested anywhere.Expected values derived by running the current tools. Verified locally:
pixi run pyteston both files → 4 passed (2 existing + 2 new).🤖 Generated with Claude Code