Skip to content

Make the search query more flexible#88

Open
kneirinck wants to merge 3 commits intodeerawan:masterfrom
kneirinck:master
Open

Make the search query more flexible#88
kneirinck wants to merge 3 commits intodeerawan:masterfrom
kneirinck:master

Conversation

@kneirinck
Copy link
Copy Markdown

Changelog

Make it possible to configure the search URI and also exclude the docsets from the search query.
As such you can use this extension with https://github.com/egoist/devdocs-desktop on macOS by setting the URI to devdocs://search/ and excluding the docsets.

Checklist

  • Code compiles correctly
  • Add or update tests, if possible
  • All tests passing
  • Update the README, if necessary
  • New contributor? added myself via npm run contributor:add

@deerawan
Copy link
Copy Markdown
Owner

@kneirinck Hi, thanks for submitting a PR. 💪🏼

A question from me, could we use this to open devdocs web as well?

Instead of making searchURI as free text, would it be better to make it fixed to devdocs uri?

@kneirinck
Copy link
Copy Markdown
Author

A question from me, could we use this to open devdocs web as well?

Good question! I've just tested it and it does indeed, but it can be done for any website I guess.

Instead of making searchURI as free text, would it be better to make it fixed to devdocs uri?

Well the devdocs macos application uses devdocs://search/, the website version would use https://devdocs.io/#q=.
So I don't think having some fixed option here is possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants