skip bot tests for 26.x: minecraft-protocol doesn't support the new version yet

The mineflayer test bot crashes on 26.1.2 with "unsupported protocol
version: 26.1.2" because minecraft-protocol/minecraft-data haven't
added protocol mappings for the new Minecraft versioning scheme yet.

See failing run:
https://github.com/def9a2a4/BlockShips/actions/runs/25650786286/job/75288572862

For 26.x, CI now runs a server-startup-only test (new Makefile target)
that verifies the server starts and BlockShips loads without errors,
skipping the bot integration tests. All 1.21.x versions still run the
full bot test suite.

Depends on upstream support:
- PrismarineJS/minecraft-data#1184
- PrismarineJS/node-minecraft-protocol#1481

Author: def9a2a4

.github/workflows/server-test.yml

@@ -25,12 +25,16 @@ jobs:
           distribution: 'temurin'
           java-version: ${{ startsWith(matrix.minecraft, '26.') && '25' || '21' }}
 
+      # TODO: remove 26.x skip conditions once minecraft-protocol supports 26.x
+      # tracking: https://github.com/PrismarineJS/minecraft-data/pull/1184
       - name: Set up Node.js
+        if: ${{ !startsWith(matrix.minecraft, '26.') }}
         uses: actions/setup-node@v4
         with:
           node-version: '20'
 
       - name: Install bot dependencies
+        if: ${{ !startsWith(matrix.minecraft, '26.') }}
         run: make test-bot-install
 
       - name: Download plugin JAR
@@ -46,8 +50,13 @@ jobs:
         run: make test-server-setup
 
       - name: Run test server with bot
+        if: ${{ !startsWith(matrix.minecraft, '26.') }}
         run: make test-server-ci MINECRAFT_VERSION=${{ matrix.minecraft }}
 
+      - name: Server startup test (no bot)
+        if: ${{ startsWith(matrix.minecraft, '26.') }}
+        run: make test-server-startup-only MINECRAFT_VERSION=${{ matrix.minecraft }}
+
       - name: Check for errors
         if: always()
         run: |

Makefile

@@ -142,6 +142,76 @@ test-bot-run: test-bot-enable-debug-glow test-bot-write-version
 test-chunk-bot-run: test-bot-write-version
 	cd test-bot && npm run test:chunk
 
+# Server startup test only (used by CI for versions where the bot doesn't work yet)
+# Starts server, verifies plugin loads, checks for errors, then shuts down
+.PHONY: test-server-startup-only
+test-server-startup-only:
+	@cd $(TEST_SERVER_DIR) && \
+	mkfifo server_input 2>/dev/null || true; \
+	tail -f server_input | java -Xmx1G -Xms1G -jar server.jar nogui > server.log 2>&1 & \
+	SERVER_PID=$$!; \
+	sleep 0.5; \
+	tail -f server.log & \
+	TAIL_PID=$$!; \
+	echo "Waiting for server to start..."; \
+	for i in $$(seq 1 600); do \
+		if grep -q "Done.*For help" server.log 2>/dev/null; then \
+			echo ""; \
+			echo "========== Server started successfully =========="; \
+			break; \
+		fi; \
+		if ! kill -0 $$SERVER_PID 2>/dev/null; then \
+			echo ""; \
+			echo "========== Server process died unexpectedly =========="; \
+			cat server.log; \
+			exit 1; \
+		fi; \
+		sleep 1; \
+	done; \
+	if ! grep -q "Done.*For help" server.log 2>/dev/null; then \
+		echo ""; \
+		echo "========== Server startup timed out =========="; \
+		cat server.log; \
+		kill $$TAIL_PID 2>/dev/null || true; \
+		kill $$SERVER_PID 2>/dev/null || true; \
+		rm -f server_input; \
+		exit 1; \
+	fi; \
+	if ! grep -q "BlockShips.*enabled" server.log; then \
+		echo "✗ BlockShips plugin failed to load"; \
+		cat server.log; \
+		kill $$TAIL_PID 2>/dev/null || true; \
+		kill $$SERVER_PID 2>/dev/null || true; \
+		rm -f server_input; \
+		exit 1; \
+	fi; \
+	echo "✓ BlockShips plugin loaded"; \
+	echo ""; \
+	echo "========== Shutting down server =========="; \
+	echo "stop" > server_input; \
+	for i in $$(seq 1 30); do \
+		if ! kill -0 $$SERVER_PID 2>/dev/null; then \
+			break; \
+		fi; \
+		sleep 1; \
+	done; \
+	kill $$TAIL_PID 2>/dev/null || true; \
+	kill $$SERVER_PID 2>/dev/null || true; \
+	rm -f server_input; \
+	rm -f errors.log; \
+	FAILED=0; \
+	if grep -qE "ERROR.*BlockShips|BlockShips.*Exception" server.log 2>/dev/null; then \
+		echo "=== SERVER ERRORS ===" | tee -a errors.log; \
+		grep -E "ERROR.*BlockShips|BlockShips.*Exception" server.log | tee -a errors.log; \
+		FAILED=1; \
+	fi; \
+	if [ $$FAILED -eq 1 ]; then \
+		echo "✗ Tests failed"; \
+		exit 1; \
+	else \
+		echo "✓ Server startup test passed"; \
+	fi
+
 # Full integration test with bot (used by CI)
 # Starts server, waits for ready, OPs the bot, runs bot tests, then shuts down
 .PHONY: test-server-ci

TODO.md

@@ -17,6 +17,9 @@
 
 ## LONG TERM
 
+- [ ] Re-enable bot tests for 26.x once `minecraft-protocol` supports it. Currently only server startup is tested.
+  - https://github.com/PrismarineJS/minecraft-data/pull/1184
+  - https://github.com/PrismarineJS/node-minecraft-protocol/pull/1481
 - [ ] ShipRegistry uses non-thread-safe HashMap but is accessed from multiple threads (chunk events, periodic saves). Use ConcurrentHashMap to prevent ConcurrentModificationException.
 - [ ] (pre-1.21.9) Rotation logic bug - delta rotation math in ShipInstance.java:1110-1130 has inconsistencies, displays may rotate incorrectly
 - [ ] (pre-1.21.9) Custom ship spawnYaw mismatch - initial spawn uses vehicle.getYaw() but recovery uses model.initialRotation.x, causing rotation snap after restart