Add support of '--min-api' d8 argument - #1000
Merged
Merged
Conversation
Summary - Extender code coverage reportSummary
Coveragecom/defold/extender - 29.5%
com/defold/extender/builders - 0%
com/defold/extender/cache - 33.3%
com/defold/extender/cache/info - 100%
com/defold/extender/log - 14.2%
com/defold/extender/metrics - 38.8%
com/defold/extender/process - 52.7%
com/defold/extender/remote - 95.6%
com/defold/extender/services - 44.1%
com/defold/extender/services/cocoapods - 51.9%
com/defold/extender/services/data - 80.7%
com/defold/extender/tracing - 21.8%
com/defold/extender/utils - 0%
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47327a7c6f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| // Reaches the command line as the argument of d8 --min-api, so it must be a bare number. | ||
| Object minAndroidSdkVersion = appContext.get(ExtenderBuildState.APPMANIFEST_MIN_ANDROID_SDK_VERSION_KEYWORD); | ||
| if (minAndroidSdkVersion != null && !(minAndroidSdkVersion instanceof Integer)) { |
There was a problem hiding this comment.
For an unquoted YAML value such as minAndroidSdkVersion: -1, SnakeYAML produces an Integer, so this condition skips validation entirely; getAppManifestContextInteger() then preserves -1 and buildClassesDex() renders it as d8 --min-api -1, causing the Android dex build to fail. The equivalent quoted value is rejected, so validate integer instances against a positive API-level range as well.
Useful? React with 👍 / 👎.
AGulev
approved these changes
Jul 27, 2026
| static final String APPMANIFEST_DEBUG_SOURCE_PATH = "debugSourcePath"; | ||
| static final String APPMANIFEST_MIN_ANDROID_SDK_VERSION_KEYWORD = "minAndroidSdkVersion"; | ||
|
|
||
| static final int DEFAULT_MIN_ANDROID_SDK_VERSION = 21; |
Contributor
There was a problem hiding this comment.
Don't we pass it from somewhere in configs? I thought we have it somewhere specified based on toolchain
Contributor
Author
There was a problem hiding this comment.
We pass ndk min version and right now there are no unified approach to manage ndk and sdk minimum version. I think it should be fixed as part of #726
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
--min-apiargument tod8. Should fix defold/extension-admob#66Related changes: defold/defold#12834