Skip to content

Commit 4c11593

Browse files
committed
fix: changed boolean to string variables in pipelines, as boolean kept breaking in odd ways.
1 parent 5ebfa31 commit 4c11593

3 files changed

Lines changed: 16 additions & 12 deletions

File tree

Infrastructure/main.bicep

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ param adoOrganizationUrl string = ''
88
param adoProjectName string = ''
99
param adoRepositoryName string = ''
1010

11-
@description('Enable EntraID authentication via Easy Auth')
11+
@description('Enable EntraID authentication')
1212
param enableEntraIdAuth bool = false
1313

1414
@description('Azure AD App Registration Client ID')
@@ -24,7 +24,7 @@ param entraIdTenantId string = subscription().tenantId
2424
@description('Comma-separated list of Azure AD Group Object IDs allowed to access (empty = all tenant users)')
2525
param entraIdAllowedGroups string = ''
2626

27-
@description('Disable password authentication (EntraID only)')
27+
@description('Disable password authentication')
2828
param disablePasswordAuth bool = false
2929

3030
var location = resourceGroup().location

Setup/azure-pipelines-deploy-jobs.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,11 @@ parameters:
4242
type: string
4343
default: ''
4444
- name: enableEntraIdAuth
45-
type: boolean
46-
default: false
45+
type: string
46+
default: 'false'
4747
- name: disablePasswordAuth
48-
type: boolean
49-
default: false
48+
type: string
49+
default: 'false'
5050
- name: entraIdAllowedGroups
5151
type: string
5252
default: ''
@@ -75,8 +75,8 @@ steps:
7575
--parameters entraIdTenantId="${{ parameters.azureTenantId }}" `
7676
--parameters entraIdClientId="${{ parameters.azureClientId }}" `
7777
--parameters entraIdClientSecret="${{ parameters.azureClientSecret }}" `
78-
--parameters enableEntraIdAuth=${{ parameters.enableEntraIdAuth }} `
79-
--parameters disablePasswordAuth=${{ parameters.disablePasswordAuth }} `
78+
--parameters enableEntraIdAuth="${{ parameters.enableEntraIdAuth }}" `
79+
--parameters disablePasswordAuth="${{ parameters.disablePasswordAuth }}" `
8080
--parameters entraIdAllowedGroups="${{ parameters.entraIdAllowedGroups }}" `
8181
| ConvertFrom-Json
8282

Setup/azure-pipelines-external.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,18 @@
1616
# - WebsitePassword
1717
# - WebsiteSessionSecret
1818
# - WebsiteName
19-
# - AzureTenantId
20-
# - AzureClientId
21-
# - AzureClientSecret
19+
# - AzureTenantId (for Dataverse access during build)
20+
# - AzureClientId (for Dataverse access during build)
21+
# - AzureClientSecret (for Dataverse access during build)
2222
# - DataverseUrl
2323
# - AdoWikiName
2424
# - AdoWikiPagePath
2525
# - AdoRepositoryName
26-
# - EntraIdAllowedGroups
26+
#
27+
# Optional variables (for Entra ID authentication):
28+
# - EnableEntraIdAuth (string: 'true' or 'false', default: 'false')
29+
# - DisablePasswordAuth (string: 'true' or 'false', default: 'false')
30+
# - EntraIdAllowedGroups (comma-separated list of Entra ID group object IDs)
2731

2832
trigger: none
2933
pr: none

0 commit comments

Comments
 (0)