Merge pull request #324 from delegateas/fix/303-delete-target-in-post-operation-plugin

Fix error when deleting target record in post-operation plugin

Author: magesoe

src/XrmMockup365/Core.cs

@@ -975,13 +975,13 @@ internal OrganizationResponse Execute(OrganizationRequest request, EntityReferen
                     var entityLogicalName = ((Entity)request.Parameters["Target"]).LogicalName;
                     var reference = primaryRef ?? new EntityReference(entityLogicalName, createResponse.id);
 
-                    var createdEntity = GetDbRow(reference).ToEntity();
+                    var createdEntity = TryRetrieve(reference);
                     TriggerExtension(
                         new MockupService(this, userRef.Id, pluginContext), request,
                         createdEntity, null, userRef);
                     break;
                 case "Update":
-                    var updatedEntity = GetDbRow(primaryRef).ToEntity();
+                    var updatedEntity = TryRetrieve(primaryRef);
                     TriggerExtension(
                         new MockupService(this, userRef.Id, pluginContext), request,
                         updatedEntity, preImage, userRef);

tests/TestPluginAssembly365/Plugins/AccountDeleteInPostPlugin.cs

@@ -0,0 +1,32 @@
+
+namespace DG.Some.Namespace {
+    using System;
+    using DG.XrmFramework.BusinessDomain.ServiceContext;
+    using TestPluginAssembly365.Plugins.SyncAsyncTest;
+    using XrmPluginCore;
+    using XrmPluginCore.Enums;
+
+    /// <summary>
+    /// Test plugin that deletes the target account in a post-Update operation.
+    /// Used to verify that XrmMockup handles record deletion inside a post-operation plugin gracefully.
+    /// </summary>
+    public class AccountDeleteInPostPlugin : TestPlugin {
+        public AccountDeleteInPostPlugin() {
+#pragma warning disable CS0618 // Type or member is obsolete - disabled for testing purposes
+            RegisterPluginStep<Account>(
+                EventOperation.Update,
+                ExecutionStage.PostOperation,
+                Execute);
+#pragma warning restore CS0618 // Type or member is obsolete
+        }
+
+        protected void Execute(LocalPluginContext localContext) {
+            if (localContext == null) {
+                throw new ArgumentNullException("localContext");
+            }
+
+            var service = localContext.OrganizationService;
+            service.Delete(Account.EntityLogicalName, localContext.PluginExecutionContext.PrimaryEntityId);
+        }
+    }
+}

tests/XrmMockup365Test/TestPlugins.cs

@@ -220,5 +220,33 @@ public void TestExecutesLegacyDaxifPlugins_Update()
                 );
             }
         }
+
+        [Fact]
+        public void TestDeleteTargetInPostUpdatePlugin()
+        {
+            crm.DisableRegisteredPlugins(true);
+            crm.RegisterAdditionalPlugins(DG.Tools.XrmMockup.PluginRegistrationScope.Temporary, typeof(DG.Some.Namespace.AccountDeleteInPostPlugin));
+
+            var account = new Account { Name = "DeleteMe" };
+            account.Id = orgAdminService.Create(account);
+
+            // Update triggers AccountDeleteInPostPlugin which deletes the account — should not throw
+            var update = new Account { Id = account.Id, Name = "Updated" };
+            orgAdminService.Update(update);
+
+            // Verify the account was actually deleted by the plugin
+            var retrieved = orgAdminService.RetrieveMultiple(
+                new QueryExpression(Account.EntityLogicalName)
+                {
+                    Criteria = new FilterExpression
+                    {
+                        Conditions =
+                        {
+                            new ConditionExpression("accountid", ConditionOperator.Equal, account.Id)
+                        }
+                    }
+                });
+            Assert.Empty(retrieved.Entities);
+        }
     }
 }