input: do not explicitly prohibit 'admin' as a password.#4831
input: do not explicitly prohibit 'admin' as a password.#4831richardhenwood-dell wants to merge 2 commits into
Conversation
fixes dell#4830 Signed-off-by: Richard Henwood <richard.henwood@dell.com>
| "minLength": 8, | ||
| "maxLength": 128, | ||
| "pattern": "^(?!admin$)[^\\\\'\"]+$", | ||
| "pattern": "^[^\\\\\\-'\"]+$", |
There was a problem hiding this comment.
is this change required? can you modify description as well
There was a problem hiding this comment.
requires a validation having admin as password as admin for minio flow
There was a problem hiding this comment.
thanks for this feedback. I had a chat with @priti-parate - there appears to be a historical reason why 'admin' was prohibited. If we can discover that and it is still relevant than I think this PR can be changed: line 109 s/Should/Must/.
let's see if we can unearth weather 'admin' is prohibited by a rule, or not :)
There was a problem hiding this comment.
looks good. can you update error message instead of the rule
There was a problem hiding this comment.
ok, I've updated the text to remove the info about 'admin'. 'admin' cannot be used for at least one reason: it is less than 8 characters. We don't need to call it out specifically.
However, now the title of this PR is incorrect. I will update that.
'admin' cannot be used as a password because it is less than 8 characters. Minio requires at least 8 characters password... and it is probably a reasonable rule to follow for Powerscale as well. Signed-off-by: richardhenwood-dell <richard.henwood@dell.com>
richardhenwood-dell
changed the title
2 participants
input: allow admin as a password
Fixes #4830