feat: Image Build Manager Refactoring#4860
Merged
Merged
Conversation
abhishek-sa1
force-pushed
the
pub/q3_main
branch
2 times, most recently
from
July 17, 2026 09:31
3c627c8 to
e0890af
Compare
Signed-off-by: Abhishek S A <abhishek.sa3@dell.com>
abhishek-sa1
force-pushed
the
pub/q3_main
branch
from
July 20, 2026 13:55
38db664 to
75f1690
Compare
Signed-off-by: Abhishek S A <abhishek.sa3@dell.com>
abhishek-sa1
marked this pull request as ready for review
July 20, 2026 16:19
abhishek-sa1
requested review from
Rajeshkumar-s2,
priti-parate,
snarthan and
sujit-jadhav
July 20, 2026 16:19
sujit-jadhav
approved these changes
Jul 21, 2026
priti-parate
approved these changes
Jul 21, 2026
sujit-jadhav
pushed a commit
to sujit-jadhav/omnia
that referenced
this pull request
Jul 21, 2026
* feat(build_manager): complete image build manager refactoring Signed-off-by: Abhishek S A <abhishek.sa3@dell.com> * Github flow update Signed-off-by: Abhishek S A <abhishek.sa3@dell.com> --------- Signed-off-by: Abhishek S A <abhishek.sa3@dell.com> Signed-off-by: Sujit Jadhav <sujit.jadhav@dell.com>
sujit-jadhav
added a commit
to sujit-jadhav/omnia
that referenced
this pull request
Jul 21, 2026
* feat(build_manager): complete image build manager refactoring Signed-off-by: Abhishek S A <abhishek.sa3@dell.com> * Github flow update Signed-off-by: Abhishek S A <abhishek.sa3@dell.com> --------- Signed-off-by: Abhishek S A <abhishek.sa3@dell.com> Signed-off-by: Sujit Jadhav <sujit.jadhav@dell.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image Build Manager — PR Refactoring Summary
Overview
This document summarizes all changes in the image_build_manager PR (formerly
build_manager).The domain builds OS boot images (kernel, initramfs, rootfs) for x86_64 and aarch64 architectures,
manages S3 storage (MinIO), container registry deployment, and produces
build_status.ymlconsumed by the provision domain.
1. Domain Rename: build_manager → image_build_manager
1. Domain Structure
src/image_build_manager/image_build_manager.ymlimage_build_config.ymlimage_build_credentials.ymlimage_build_credential.j2.image_build_credentials_keyinput/project_default/image_build_manager/output/project_default/image_build_manager/image_build_manager.logimage_build_managerSub-playbooks
prepare_image_build_manager.ymlrollback_image_build_manager.ymlupgrade_image_build_manager.ymlFiles Created/Updated
src/image_build_manager/playbooks/src/image_build_manager/roles/src/image_build_manager/ansible.cfgandplaybooks/ansible.cfgsrc/image_build_manager/vars/image_vars.ymlsrc/image_build_manager/input/image_build_config.ymlsrc/image_build_manager/samples/repo_status.ymlandbuild_status.ymlsrc/playbooks/utils/credential_utility/roles/*/vars/main.ymlsrc/playbooks/utils/roles/common/vars/main.ymlandtasks/main.ymlsrc/playbooks/utils/roles/common/tasks/include_image_build_credentials.ymlsrc/playbooks/input_validation/validate_config.ymlsrc/common/library/module_utils/input_validation/common_utils/config.pysrc/main/omnia.shsrc/main/containers/build_images.shsrc/playbooks/prepare_oim/roles/deploy_containers/openchami/tasks/configs/main.yml2. Credential Ownership Transfer
s3_secret_keyomnia_config_credentials.ymlimage_build_credentials.ymlonlys3_access_idomnia_config_credentials.ymlimage_build_credentials.ymlonlyprovision_passwordomnia_config_credentials.ymlimage_build_credentials.yml(mandatory)pulp_passwordomnia_config_credentials.ymlomnia_config_credentials.yml3. Pulp Details Read from repo_status.yml
All hardcoded Pulp paths removed from image_build_manager flow.
Pulp certificate paths, repo file paths, and registry details are now read from
repo_status.yml(produced by repo_manager) in Step 3 ofimage_build_manager.yml.repo_status.yml Contract
Producer: repo_manager domain
Consumer: image_build_manager (Step 3 pre-check)
Location:
output/project_default/repo_manager/repo_status.ymlFacts Set from repo_status.yml
pulp_webserver_cert_pathrepo_manager.certificates.server_crtpulp_portrepo_manager.portrepo_manager_repos_x86_64rpm_repos.x86_64and user_repos.x86_64(loop-basedset_fact`)repo_manager_repos_aarch64rpm_repos.aarch64anduser_repos.aarch64(loop-basedset_fact)Validation Rules
overall_statusmust be"success"— fails build if notrepo_managersection must exist withcertificates.server_crtandportrpm_reposmust contain valid URLs for target architecturesRepo List Construction (Fixed)
Repo URLs from
rpm_reposdict are converted to list of{name, base_url, gpg}objectsusing loop-based
set_fact(not Jinja2 string template — avoids serialization issues):Each repo entry is passed to
rhel-compute-config.yaml.j2template asrhel_arch_repos.Role Vars Updated
roles/image_creation/vars/main.yml—pulp_cert_host_path,pulp_webserver_cert_path,and container mounts now reference
hostvars['localhost']factsroles/prepare_arm_node/vars/main.yml—pulp_repo_store_path,pulp_webserver_cert_path,ochami_aarch_64_dirnow reference factsroles/image_creation/tasks/prepare_pulp_image.yml— registry port from factsroles/prepare_arm_node/tasks/main.yml— registry port from facts4. build_status.yml Output Contract
Producer: image_build_manager (Step 8)
Consumer: provision domain (BSS template rendering)
Location:
output/project_default/build_status.ymloutput/project_default/image_build_manager/build_status_<version>_<timestamp>.ymlS3 Endpoint Behavior:
http://<admin_nic_ip>:9000whenendpoint_urlis emptyendpoint_urlas-is (preserves original)Output Implementation:
roles/image_creation/templates/build_status.yml.j2build_completed_images | dict2itemsto produce arch-grouped YAMLwrite_build_status.ymlinroles/image_creation/tasks/(duplicate infetch_packagesremoved)5. Container Build Scripts
src/image_build_manager/containers/build_images.sh— self-contained image-builder build (no_common.shdependency)src/containers/→src/main/containers/— core containers separated from domainsrc/image_build_manager/containers/image_builder/build.sh— consolidated intobuild_images.sh6. Input Validation & Schema
JSON Schemas Added
src/common/.../schema/image_build_config.json— validatesimage_build_config.ymlsrc/common/.../schema/image_build_credentials.json— validatesimage_build_credentials.ymlconfig.py Updates
filesdict: addedimage_build_configentryinput_file_inventory:image_build_managertag validatesimage_build_config.yml+software_config.jsonget_vault_password(): mapsimage_build_credentials.yml→.image_build_credentials_key7. MinIO/Registry Deployment
Moved from
prepare_oimtoimage_build_manager:roles/deploy_minio/— MinIO container, S3 buckets, ACL policiesroles/deploy_registry/— Local container registryDeployed by
prepare_image_build_manager.yml(Step 5 ofimage_build_manager.yml).8. End-to-End Flow
File Locations
9. Upgrade & Rollback Compatibility
omnia_config_credentials.ymlare automatically migratedto
image_build_credentials.yml.image_build_credentials.ymldoesn't exist yet.10. Backward Compatibility
image_build_config.ymlis required — no legacy fallback tostorage_config.yml.s3_configurations.endpoint_urladded for explicit S3 endpoint configuration.src/image_build_manager/containers/and removed from central
src/main/containers/build_images.sh.build_image_x86_64.yml,build_image_aarch64.yml) work independentlywith proper credential utility integration and image_build_config loading.
fixes #4847
fixes #4849