handle stale mount and fstab entries during#4867
Open
Nagachandan-P wants to merge 2 commits into
Open
Conversation
reinstall Signed-off-by: Nagachandan-P <Nagachandan.p@dell.com>
| mkdir -p $omnia_path | ||
|
|
||
| # Remove any stale mount or fstab entry for omnia_path before reuse | ||
| echo -e "${BLUE} Checking for existing mount at $omnia_path.${NC}" |
Collaborator
There was a problem hiding this comment.
stale should be removed as part of uninstall flow. also to be taken care of slurm and k8s share
…cleanup - omnia.sh --install: unmount existing omnia_path and remove stale /etc/fstab entries before mounting a new NFS share. - omnia.sh --uninstall: always unmount omnia_path and remove its /etc/fstab entry, regardless of metadata state. - oim_cleanup.yml: unmount and remove /etc/fstab entries for slurm and k8s OIM mounts with mount_on_oim: true. Signed-off-by: Nagachandan-P <Nagachandan.p@dell.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this fix, omnia.sh --install does the following before mounting:
• If yes, it unmounts the existing share.
• If umount fails, it tries a lazy unmount.
• If both fail, it exits with a clear error and asks the user to unmount manually.
• If found, it backs up /etc/fstab and removes the stale entry.