Skip to content

[test] add missing sparc2-nidaq-scan-stage-sim mic file#3475

Open
pieleric wants to merge 1 commit into
delmic:masterfrom
pieleric:test-add-missing-sparc2-nidaq-scan-stage-sim-mic-file
Open

[test] add missing sparc2-nidaq-scan-stage-sim mic file#3475
pieleric wants to merge 1 commit into
delmic:masterfrom
pieleric:test-add-missing-sparc2-nidaq-scan-stage-sim-mic-file

Conversation

@pieleric
Copy link
Copy Markdown
Member

Used by src/odemis/acq/stream/test/stream_sparc2_vec_stage_test.py

Also update the "standard" sparc2-nidaq-sim file with the minor fixes
done in that new microscope file.

Used by src/odemis/acq/stream/test/stream_sparc2_vec_stage_test.py

Also update the "standard" sparc2-nidaq-sim file with the minor fixes
done in that new microscope file.
Copilot AI review requested due to automatic review settings May 29, 2026 14:56
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the missing simulated SPARC2 NIDAQ scan-stage microscope configuration used by scan-stage stream tests and aligns the standard NIDAQ simulation with the same minor configuration fixes.

Changes:

  • Adds a new sparc2-nidaq-scan-stage-sim.odm.yaml simulator configuration with scan-stage support and no SEM-to-CCD hardware synchronization.
  • Updates the standard sparc2-nidaq-sim.odm.yaml config for camera stage effects, spectrograph filter band definition, and optical lens persistence behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
install/linux/usr/share/odemis/sim/sparc2-nidaq-sim.odm.yaml Applies minor simulator configuration fixes shared with the new scan-stage setup.
install/linux/usr/share/odemis/sim/sparc2-nidaq-scan-stage-sim.odm.yaml Adds the missing simulated SPARC2 NIDAQ scan-stage microscope file used by stream tests.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9ae99e17-ea96-4f5f-a07d-e09c6eab18c1

📥 Commits

Reviewing files that changed from the base of the PR and between 3e12d1e and 490bcbf.

📒 Files selected for processing (2)
  • install/linux/usr/share/odemis/sim/sparc2-nidaq-scan-stage-sim.odm.yaml
  • install/linux/usr/share/odemis/sim/sparc2-nidaq-sim.odm.yaml

📝 Walkthrough

Walkthrough

This pull request introduces a complete SPARC v2 simulator configuration backed by NIDAQmx, alongside minor refinements to the existing base simulator configuration. The new file implements a full microscope stack: system entry and power distribution; SEM electron beam scanning with TTL-based CCD synchronization and analog detection; cathodoluminescence PMT subsystem; sample stage motion affecting both e-beam and camera; composited spectrometer from camera and Shamrock spectrograph with optical routing; optical platform actuators controlling lenses, slits, filters, and selectors; and mirror alignment with coordinate transformation into SEM space. Parallel updates to the existing configuration add TTL synchronization documentation, couple the sample stage to the camera, correct a filter wheel wavelength band, and clean up optical path properties.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a missing sparc2-nidaq-scan-stage-sim microscope configuration file for tests.
Description check ✅ Passed The description is related to the changeset, explaining which test file uses the new configuration and that minor fixes were backported to the existing file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pieleric pieleric requested a review from nandishjpatel May 29, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants