[test] add missing sparc2-nidaq-scan-stage-sim mic file#3475
Conversation
Used by src/odemis/acq/stream/test/stream_sparc2_vec_stage_test.py Also update the "standard" sparc2-nidaq-sim file with the minor fixes done in that new microscope file.
There was a problem hiding this comment.
Pull request overview
This PR adds the missing simulated SPARC2 NIDAQ scan-stage microscope configuration used by scan-stage stream tests and aligns the standard NIDAQ simulation with the same minor configuration fixes.
Changes:
- Adds a new
sparc2-nidaq-scan-stage-sim.odm.yamlsimulator configuration with scan-stage support and no SEM-to-CCD hardware synchronization. - Updates the standard
sparc2-nidaq-sim.odm.yamlconfig for camera stage effects, spectrograph filter band definition, and optical lens persistence behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
install/linux/usr/share/odemis/sim/sparc2-nidaq-sim.odm.yaml |
Applies minor simulator configuration fixes shared with the new scan-stage setup. |
install/linux/usr/share/odemis/sim/sparc2-nidaq-scan-stage-sim.odm.yaml |
Adds the missing simulated SPARC2 NIDAQ scan-stage microscope file used by stream tests. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request introduces a complete SPARC v2 simulator configuration backed by NIDAQmx, alongside minor refinements to the existing base simulator configuration. The new file implements a full microscope stack: system entry and power distribution; SEM electron beam scanning with TTL-based CCD synchronization and analog detection; cathodoluminescence PMT subsystem; sample stage motion affecting both e-beam and camera; composited spectrometer from camera and Shamrock spectrograph with optical routing; optical platform actuators controlling lenses, slits, filters, and selectors; and mirror alignment with coordinate transformation into SEM space. Parallel updates to the existing configuration add TTL synchronization documentation, couple the sample stage to the camera, correct a filter wheel wavelength band, and clean up optical path properties. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Used by src/odemis/acq/stream/test/stream_sparc2_vec_stage_test.py
Also update the "standard" sparc2-nidaq-sim file with the minor fixes
done in that new microscope file.